Re: [Xen-devel] Test report for xen-unstable and qemu-xen

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.07.13 at 10:25, Matthew Daley <mattjd@xxxxxxxxx> wrote:
> On Tue, Jul 2, 2013 at 2:07 AM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>>>> On 01.07.13 at 15:50, Stefano Stabellini 
>>>>> <stefano.stabellini@xxxxxxxxxxxxx> 
> wrote:
>>> On Mon, 1 Jul 2013, Fabio Fantoni wrote:
>>>> - on W7 pro 64 bit domU error in the begin of qemu log, while domU seem to
>>>> work:
>>>> xc: error: linux_gnttab_set_max_grants: ioctl SET_MAX_GRANTS failed (22 =
>>>> Invalid argument): Internal error
>>>> xen be: qdisk-832: xc_gnttab_set_max_grants failed: Invalid argument
>>>> -------------------------
>>>
>>> This is an harmless message if you are running a pvops kernel, it only
>>> indicates a problem if you are running on a SUSE kernel.
>>>
>>> Jan, could we figure out from the return code whether it was a real
>>> problem and only print an error in that case?
>>> I think that users might get confused otherwise.
>>
>> This is supposed to happen already, by special casing the ENOTTY
>> errno value. Question is why EINVAL is being seen here instead.
> 
> Probably because
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/fs/io 
> ctl.c?id=07d106d0a33d6063d2061305903deb02489eba20
> only went in time for Linux 3.3 (it's not in my Debian unstable, for 
> example).

Very much so, and kernels should be backporting this if upstream
didn't.

> I personally use the patch below to keep a clean log (I see this
> message too), but I'm sure it would be NAK'd for continuing the
> ENOTTY/EINVAL confusion and making legitmate EINVALs disappear.
> Perhaps instead the message could be softened from an error to a
> warning?

Making this a warning may be acceptable, but I'm not eager to work
around kernel bugs like this (and in effect risk hiding _real_ errors,
which ought to not be logged as just a warning).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel