[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH (V9) 2/2] xen: Add V4V implementation

>>>> Ross Philipson <ross.philipson@xxxxxxxxxx> 05/29/13 9:26 PM >>>
>On 05/29/2013 04:34 AM, Jan Beulich wrote:
>>>>> On 28.05.13 at 21:43, Ross Philipson<ross.philipson@xxxxxxxxxx>  wrote:
>>> --- a/xen/include/xen/sched.h
>>> +++ b/xen/include/xen/sched.h
>>> @@ -24,6 +24,7 @@
>>>   #include<public/sysctl.h>
>>>   #include<public/vcpu.h>
>>>   #include<public/mem_event.h>
>>> +#include<xen/v4v.h>
>> Please don't, or if you absolutely have to, not after the public
>> headers, but along with the other xen/ ones.
>>> --- /dev/null
>>> +++ b/xen/include/xen/v4v.h
>>> ...
>>> +struct v4v_domain;
>> What is this good for? There's no use in any of the following
>> function declarations.
>It is a forward declaration of the main internal v4v struct. It is used 
>in sched.h in the domain struct - thus the #include you asked about 
>earlier. I will of course move that include.

Delete, not move - note my mentioning of function declarations. An incomplete
structure being used in another structure or union is no problem without
forward declaration - it serves as a forward declaration itself. This would only
be a problem in C++, but this is a non-public header, so C++ is of no concern.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.