[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] tools: fix dependency file generation

On Thu, 2013-05-16 at 15:48 +0100, Jan Beulich wrote:
> There is a small set of places where files in subdirectories get
> compiled from the parent directory. Dependency file wise this is no
> problem as long as the files use names distinct without regard to the
> directories they sit in, and tools/console/ violates this (in having
> two main.c files). Hence we need to avoid losing the directory name,
> both to ensure the two compiler instances don't simultaneously write
> to the same file (happening of which is what triggered me looking
> into this) and to guarantee dependencies for all files will be seen
> by make on an incremental rebuild.
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Took me a while to grok the make functions (short answer foo/bar.o
=> .foo@xxxxxxx). Looks good:

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> --- a/tools/Rules.mk
> +++ b/tools/Rules.mk
> @@ -62,7 +62,7 @@ SHLIB_libxenlight  = -Wl,-rpath-link=$(X
>  # Get gcc to generate the dependencies for us.
> -CFLAGS += -MMD -MF .$(@F).d
> +CFLAGS += -MMD -MF .$(if $(filter-out .,$(@D)),$(subst /,@,$(@D))@)$(@F).d
>  DEPS = .*.d
>  ifneq ($(FILE_OFFSET_BITS),)

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.