Re: [Xen-devel] [PATCH 16/20] PVH xen: Miscellaneous changes

[Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>]

On Wed, 15 May 2013 12:53:00 +0100
"Jan Beulich" <JBeulich@xxxxxxxx> wrote:

> >>> On 15.05.13 at 02:52, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
> >>> wrote:
> > --- a/xen/arch/x86/domctl.c
> > +++ b/xen/arch/x86/domctl.c
> > @@ -64,9 +64,10 @@ long domctl_memory_mapping(struct domain *d,
> > unsigned long gfn, 
> >      if ( add_map )
> >      {
> > -        printk(XENLOG_G_INFO
> > -               "memory_map:add: dom%d gfn=%lx mfn=%lx nr=%lx\n",
> > -               d->domain_id, gfn, mfn, nr_mfns);
> > +        if ( !is_pvh_domain(d) )     /* PVH maps lots and lots */
> > +            printk(XENLOG_G_INFO
> > +                   "memory_map:add: dom%d gfn=%lx mfn=%lx
> > nr=%lx\n",
> > +                   d->domain_id, gfn, mfn, nr_mfns);
> >  
> >          ret = iomem_permit_access(d, mfn, mfn + nr_mfns - 1);
> >          if ( !ret && paging_mode_translate(d) )
> > @@ -91,9 +92,10 @@ long domctl_memory_mapping(struct domain *d,
> > unsigned long gfn, }
> >      else
> >      {
> > -        printk(XENLOG_G_INFO
> > -               "memory_map:remove: dom%d gfn=%lx mfn=%lx nr=%lx\n",
> > -               d->domain_id, gfn, mfn, nr_mfns);
> > +        if ( !is_pvh_domain(d) )     /* PVH unmaps lots and lots */
> > +            printk(XENLOG_G_INFO
> > +                   "memory_map:remove: dom%d gfn=%lx mfn=%lx
> > nr=%lx\n",
> > +                   d->domain_id, gfn, mfn, nr_mfns);
> >  
> >          if ( paging_mode_translate(d) )
> >              for ( i = 0; i < nr_mfns; i++ )
> 
> Are these changes still necessary? IOW why would a PVH guest be
> mapping so much more MMIO memory than a PV one?

Right, not needed anymore since I map the IO space all upfront now in
xen. In earlier patches linux was doing it.

thanks
Mukesh


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel