Re: [Xen-devel] [PATCH] build system: build kernels subsystem on Linux only

[Ian Campbell <ian.campbell@xxxxxxxxxx>]

On Wed, 2013-05-15 at 16:05 +0200, Christoph Egger wrote:
> commit d59122a365ad40c3ff59a0be7427cccbc81aaa4a
> Author: Christoph Egger <chegger@xxxxxxxxx>
> Date:   Wed Mar 20 13:46:38 2013 +0000
> 
>     build: enable kernels subsystem on Linux only

Thanks. These targets have been pretty useless even on Linux for ages,
really they are an artefact of the time when Xen was an out of tree
patch set.

I think we should just disable them by default i.e.
s/DEFAULT_ENABLE/DEFAULT_DISABLE/ plus the Makefile hunk of your patch.

Ian.


> diff --git a/Makefile b/Makefile
> index 5a7107e..e47f29c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -7,7 +7,7 @@
>  all: dist
>  
>  -include config/Toplevel.mk
> -SUBSYSTEMS?=xen kernels tools stubdom docs
> +SUBSYSTEMS?=xen tools stubdom docs
>  TARGS_DIST=$(patsubst %, dist-%, $(SUBSYSTEMS))
>  TARGS_INSTALL=$(patsubst %, install-%, $(SUBSYSTEMS))
>  
> diff --git a/configure.ac b/configure.ac
> index ce06dad..9aafb8a 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -22,8 +22,18 @@ case "$host_cpu" in
>          ;;
>  esac
>  
> +dnl Enable kernel subsystem on Linux only
> +case "$host_os" in
> +    Linux)
> +        os_enable_kernels=y
> +        ;;
> +    *)
> +        os_enable_kernels=n
> +        ;;
> +esac
> +
>  AX_SUBSYSTEM_DEFAULT_ENABLE([xen])
> -AX_SUBSYSTEM_DEFAULT_ENABLE([kernels])
> +AX_SUBSYSTEM_CONDITIONAL([kernels], $os_enable_kernels)
>  AX_SUBSYSTEM_DEFAULT_ENABLE([tools])
>  AX_SUBSYSTEM_CONDITIONAL([stubdom], $arch_enable_stubdom)
>  AX_SUBSYSTEM_DEFAULT_ENABLE([docs])



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel