Re: [Xen-devel] [PATCH 02/13] tools/libfsimage: Fix clean and distclean make targets

[Daniel Kiper <daniel.kiper@xxxxxxxxxx>]

On Thu, May 09, 2013 at 09:17:01AM +0100, Ian Campbell wrote:

[...]

> The two sets of rules seem to be in fsimage/common/Makefile:
>
>         clean distclean:
>                 rm -f $(PIC_OBJS) $(LIB) $(DEPS)
>
> and in tools/libfsimage/Rules.mk:
>
>         clean distclean:
>                 rm -f $(PIC_OBJS) $(FSLIB) $(DEPS)
>
> Which seems a bit redundant anyway, perhaps rather than allowing both
> rules we should combine them and just have tools/libfsimage/Rules.mk:
>         clean distclean:
>                 rm -f $(PIC_OBJS) $(LIB) $(FSLIB) $(DEPS)
> ?

Yes, my last patch fixed that too. However, I think that
it is worth to change those rules to double-colon and have
one generic and some specific if required. As I saw this
solution is used in some places in Xen source. Anyway,
I will post new patch for review.

Daniel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel