[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] qemu-xen:Correctly expose PCH ISA bridge for IGD passthrough [and 2 more messages]

On Fri, May 10, 2013 at 11:33:09AM +0100, Ian Campbell wrote:
> > >> I mostly wanted to clarify the situation with these patches,
> > > Instead of adding more work to our already overburdened maintainers
> > > please start in these cases by working with the submitter.
> > >
> > > It is the submitters responsibility to respond to queries and to keep
> > > pushing the patch as necessary. If the submitter isn't engaged any more
> > > then you need to either pick it up yourself or find someone else who is
> > > willing to carry the patch forward, there's no point asking the
> > > maintainers to clarify the situation if no one is around who is going to
> > > act on their responses.
> > 
> > But if he were going to pick it up, or if he wants to go work with the 
> > submitter, who may not have a clear understanding what the delay was 
> > about or how the development process works, then he'd first need to 
> > figure out what the status was, right?
> >
> > This sort of "facilitating" role seems like a useful thing to do to 
> > allow contributions which would otherwise flounder to make it above the 
> > bar into acceptance.
> A facilitator should first ask the submitter what they think is going
> on, and try and offer them guidance, which could be fairly generic e.g.
> remind them that the need to resubmit if a patch is dropped, or it could
> be more specific, i.e. reminding them of the need to respond to
> particular queries made by the maintainers last time.

Yep, I should have talked to G.R. first. Sorry about that.

> Yes, this means they would have needed to have read the background and
> make an attempt to understand the current status first. They may not be
> able to figure it out (or might get it wrong) but at least the obvious
> cases can then be covered.

I did read all the emails in various threads related to these patches,
and I tried understanding where we are.

It was a bit confusing because for example one of the patches got applied,
then reverted, re-submitted after that, and I didn't 100% understand from
the comments if there are still unresolved issues or not. 

Now it's clear that not all of the issues are sorted out yet.

(Btw right now we're discussing in a thread that doesn't have the latest version
of the patches..)

> Facilitating can surely be useful and appreciated. But if "facilitate"
> just means pinging the maintainers without having spoken to the
> submitter, read up on the background and followed up on outstanding
> queries then it is just making more work for maintainers for no gain and
> isn't really facilitating anything.
> Remember, Submitters (and facilitators) scale while maintainers do not.

I do understand that. Thanks for your patience :)

-- Pasi

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.