[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 4/6] x86/HVM: properly handle RTC periodic timer even when !RTC_PIE

>>> On 02.05.13 at 11:41, Tim Deegan <tim@xxxxxxx> wrote:
> At 14:53 +0100 on 29 Apr (1367247238), Jan Beulich wrote:
>> Since in that case the processing it pr_intr_post() won't occur, we
>> need to do some additional work in pt_update_irq(). Additionally we
>> must not pay attention to the respective IRQ being masked.
> I don't think this is the right fix for 4.3.  We should just revert to
> the old system (where the vpt code raises the IRQ) rather than bodge up
> the new one -- especially since the new _behaviour_ is disabled anyway.

As said in a reply to George already - I always said I'd prefer to
do as little of a revert as possible for 4.3, and in the light of all
the brokenness not really originating from the changes to the
RTC emulation, I'm thinking even more so now.

While I won't ack or support a full revert, I of course also won't
stand in the way of this being done if you, George, and perhaps
Keir all agree.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.