Re: [Xen-devel] [PATCH 3/6] x86/HVM: adjust IRQ (de-)assertion

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 02.05.13 at 11:34, Tim Deegan <tim@xxxxxxx> wrote:
> At 14:53 +0100 on 29 Apr (1367247201), Jan Beulich wrote:
>> De-assertion should only happen when RTC_IRQF gets cleared, i.e. upon
>> REG_C reads. Assertion should be done only when the flag transitions
>> from 0 to 1.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Well, this seems correct to me as far as the original (level-triggered)
> RTC chip goes, but when we discussed changing this before, you suggested
> that we should keep the old (somewhat bizarre) behaviour.
> 
> Unless this is fixing an observed bug, and unless you've tested it
> widely, I don't think this is for 4.3.

This is setting the ground for (a) being fully in line with the spec
_and_ (b) reverting behavior to the 4.2 one in the final patch.
Doing that revert with the code as it is before this series is much
less clean.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel