Re: [Xen-devel] [PATCH 4/7] minios: add gnttab_find_grant_of_page

[Marek Marczykowski <marmarek@xxxxxxxxxxxxxxxxxxxxxx>]

On 29.04.2013 00:41, Samuel Thibault wrote:
> Marek Marczykowski, le Tue 23 Apr 2013 05:16:21 +0200, a Ãcrit :
>> Needed to implement minios_gntshr_munmap without introducing additional
>> mapping (frame->gref).
> 
> I agree on the principle, given the comment you have put.
> 
>> +/* This function is used by gnttab_munmap call. It is rather rare to call 
>> it -
>> + * mostly at sthudown, so save memory at price of efficiency */
> 
> Better not introduce the typo, however ;)

Oops ;)

>> +grant_ref_t
>> +gnttab_find_grant_of_page(void *map)
>> +{
>> +    unsigned long flags;
>> +    int i, mfn;
>> +    grant_ref_t ref = 0;
>> +
>> +    mfn = virt_to_mfn(map);
>> +    local_irq_save(flags);
> 
> Why disabling IRQs?

I've just copied it from get_free_entry. But indeed, as I don't modify the
table here, probably it can be dropped.

-- 
Best Regards / Pozdrawiam,
Marek Marczykowski
Invisible Things Lab

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel