[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] S3 is broken again in xen-unstable

On Fri, 2013-04-26 at 15:10 +0100, Ben Guthro wrote:
> On Fri, Apr 26, 2013 at 9:17 AM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> <snip>
> >> I'm not sure I understand this point.
> >> Are you saying you want to see a test that fails in the standard test
> >> flight first...because without Konrad's patches, it will be guaranteed
> >> not to work.
> >
> > Right. AIUI the flights (and I may be using the wrong term here) are
> > somewhat uniform and and few in number and get run with various
> > combinations inputs (Xen tree, Linux tree, Qemu tree), so there is
> > effectively one "test Linux PV kernel flight" and one "test Xen PV
> > guests flight" etc, so we want to get S3 into those flights, with the
> > existing set of "* tree" inputs.
> >
> > IOW we should add a new row to the grid
> > http://www.chiark.greenend.org.uk/~xensrcts/logs/17816/ for s3 testing
> > and then we can consider adding a new column with a different set of
> > tree's as input.
> >
> > Ian J may have a different opinion on how to approach, but he's away
> > until mid next week.
> >
> >> ...and without other changesets queued up for the 3.10 merge window,
> >> non-boot CPUs will always have incorrect C-states.
> >
> > It's OK to add the tests before things work.
> I've attached a patch to osstest that would be the beginnings of this
> sort of test, if I'm reading the code correctly.
> However, I don't really have a setup that I can smoke test this.
> I also left a number of TODOs, since I really just want an opinion to
> see if I'm on the right track.

Right track, as far as it goes, but I think most of what you have put in
TestSupport.pm should actually be in the ts-host-suspend test case

You probably need IanJ's input for anything more concrete.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.