Re: [Xen-devel] S3 is broken again in xen-unstable

[Ben Guthro <ben@xxxxxxxxxx>]

On Fri, Apr 26, 2013 at 9:17 AM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
<snip>
>> I'm not sure I understand this point.
>> Are you saying you want to see a test that fails in the standard test
>> flight first...because without Konrad's patches, it will be guaranteed
>> not to work.
>
> Right. AIUI the flights (and I may be using the wrong term here) are
> somewhat uniform and and few in number and get run with various
> combinations inputs (Xen tree, Linux tree, Qemu tree), so there is
> effectively one "test Linux PV kernel flight" and one "test Xen PV
> guests flight" etc, so we want to get S3 into those flights, with the
> existing set of "* tree" inputs.
>
> IOW we should add a new row to the grid
> http://www.chiark.greenend.org.uk/~xensrcts/logs/17816/ for s3 testing
> and then we can consider adding a new column with a different set of
> tree's as input.
>
> Ian J may have a different opinion on how to approach, but he's away
> until mid next week.
>
>> ...and without other changesets queued up for the 3.10 merge window,
>> non-boot CPUs will always have incorrect C-states.
>
> It's OK to add the tests before things work.

I've attached a patch to osstest that would be the beginnings of this
sort of test, if I'm reading the code correctly.
However, I don't really have a setup that I can smoke test this.

I also left a number of TODOs, since I really just want an opinion to
see if I'm on the right track.

Thanks
Ben

Attachment: s3-test.patch
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel