Re: [Xen-devel] [PATCH 13/17] PVH xen: p2m related changes.

[Tim Deegan <tim@xxxxxxx>]

At 14:59 -0700 on 25 Apr (1366901973), Mukesh Rathor wrote:
> On Thu, 25 Apr 2013 12:28:13 +0100
> Tim Deegan <tim@xxxxxxx> wrote:
> 
> > At 14:26 -0700 on 23 Apr (1366727162), Mukesh Rathor wrote:
> > > In this patch, I introduce  a new type p2m_map_foreign for pages
> > > that a dom0 maps from foreign domains its creating. Also, add
> > > set_foreign_p2m_entry() to map p2m_map_foreign type pages. Other
> > > misc changes related to p2m.
> > 
> > You haven't addressed my comments from v2:
> > http://lists.xen.org/archives/html/xen-devel/2013-03/msg01895.html
> > 
> > In particular this:
> > 
> > >      /* Track the highest gfn for which we have ever had a valid
> > > mapping */
> > > -    if ( p2mt != p2m_invalid &&
> > > +    if ( p2mt != p2m_invalid && p2mt != p2m_mmio_dm &&
> > >           (gfn + (1UL << order) - 1 > p2m->max_mapped_pfn) )
> > >          p2m->max_mapped_pfn = gfn + (1UL << order) - 1;
> > 
> > seems like a big change to be hiding away in a 'p2m related changes'
> > patch without a good explanation of what you're doing and why.
> > 
> > Tim.
> 
> Remember:
> http://lists.xen.org/archives/html/xen-devel/2012-03/msg02456.html

Clearly not. :)  But in fact, since then we've already made this change:
http://xenbits.xen.org/gitweb/?p=xen.git;a=commitdiff;h=b6f3a3cbf014b7adb992ffa697aca568ff7a7fcb

so I think you can just drop these changes from your patch.

Cheers,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel