Re: [Xen-devel] [PATCH 13/17] PVH xen: p2m related changes.

[Tim Deegan <tim@xxxxxxx>]

At 14:26 -0700 on 23 Apr (1366727162), Mukesh Rathor wrote:
> In this patch, I introduce  a new type p2m_map_foreign for pages that a
> dom0 maps from foreign domains its creating. Also, add
> set_foreign_p2m_entry() to map p2m_map_foreign type pages. Other misc changes
> related to p2m.

You haven't addressed my comments from v2:
http://lists.xen.org/archives/html/xen-devel/2013-03/msg01895.html

In particular this:

>      /* Track the highest gfn for which we have ever had a valid mapping */
> -    if ( p2mt != p2m_invalid &&
> +    if ( p2mt != p2m_invalid && p2mt != p2m_mmio_dm &&
>           (gfn + (1UL << order) - 1 > p2m->max_mapped_pfn) )
>          p2m->max_mapped_pfn = gfn + (1UL << order) - 1;

seems like a big change to be hiding away in a 'p2m related changes'
patch without a good explanation of what you're doing and why.

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel