[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V3 4/4] arm: allocate per-PCPU domheap pagetable pages

At 11:54 +0100 on 24 Apr (1366804441), Ian Campbell wrote:
> +    /* Some of these slots may have been used during start of day and/or
> +     * relocation. Make sure they are clear now. */
> +    memset(this_cpu(xen_dommap), 0, DOMHEAP_SECOND_PAGES*PAGE_SIZE);
> +    flush_xen_dcache_va_range(this_cpu(xen_dommap),
> +                              DOMHEAP_SECOND_PAGES*PAGE_SIZE);
> +}

This is a dcache flush -- do we need flush_xen_data_tlb_range_va()
instead (or possibly as well)?  Also: do we care about dirty cachelines
from the earlier operations?  And in that case should we flush the cache
before the PTs are cleared (and again afterwards to guard against

Tim (still not convinced my mental model of ARM memory is right...)

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.