Re: [Xen-devel] [RFC 2/6] linux-stubdomain: Compile Linux

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Anthony PERARD, le Mon 22 Apr 2013 14:46:29 +0100, a écrit :
> >> +@@ -286,9 +283,6 @@ static long privcmd_ioctl_mmap_batch(void __user 
> >> *udata)
> >> +       LIST_HEAD(pagelist);
> >> +       struct mmap_batch_state state;
> >> +
> >> +-      if (!xen_initial_domain())
> >> +-              return -EPERM;
> >> +-
> >> +       if (copy_from_user(&m, udata, sizeof(m)))
> >> +               return -EFAULT;
> >> +
> > 
> > 
> > I think you should submit both patches separately for inclusion in the
> > Linux kernel.
> 
> Definitely.
> Should we remove the check for initial_domain all together and leave
> this permission to be handle by Xen?

I would tend to say so. Since it's a matter of hypervisor security, Xen
is supposed to check that already anyway, isn't it?

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel