Re: [Xen-devel] [PATCH] xl: extend autoballoon xl.conf option with an "auto" option

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-04-04 at 14:30 +0100, Ian Jackson wrote:
> David Vrabel writes ("[PATCH] xl: extend autoballoon xl.conf option with an 
> "auto" option"):
> > autoballoon=1 is not recommened if dom0_mem was used to reduce the
> > amount of dom0 memory.  Instead of requiring users to change xl.conf
> > if they do this, extend the autoballoon option with a new choice:
> > "auto".
> 
> I really like the principle of this patch.
> 
> But:
> 
> > +
> > +Default: C<"on">
> 
> I would like to see another patch changing the default.
> 
> > +    if (strstr(info->commandline, "dom0_mem"))
> > +        return 0;
> 
> Sadly your command line parsing needs to be more sophisticated than
> this.  Consider:
> 
>  xen blah vmlinuz blah initrd.gz blah init=/etc/init.try-without-dom0_mem

You are correct although your example isn't because the Xen command line
in this case would only include the first "blah" (or else your
hypothetical bootloader which implements this syntax is doing something
non-intuitive).

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel