Re: [Xen-devel] [PATCH] docs/traces Acked patches.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-03-25 at 16:46 +0000, Konrad Rzeszutek Wilk wrote:
> On Mon, Mar 25, 2013 at 03:48:33PM +0000, Jan Beulich wrote:
> > >>> On 25.03.13 at 16:37, George Dunlap <george.dunlap@xxxxxxxxxxxxx> wrote:
> > > On 25/03/13 15:13, Jan Beulich wrote:
> > >>>>> On 25.03.13 at 15:41, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> 
> > >>>>> wrote:
> > >>> Please commit these patches. I can also put these on a git tree
> > >>> (if you could create on for me on xenbits.org that is it) for a git 
> > >>> pull.
> > >>>
> > >>>
> > >>> The trace patches have been Acked-by George.
> > >> You know what - I didn't apply them precisely because the ack
> > >> came through only for patches 3 and 4. I just checked the
> > >> xen-devel archives again, and that's the state of affairs right
> > >> now too. Possibly the ack was sent to you without Cc-ing
> > >> xen-devel, but that doesn't allow me to apply them.
> > > 
> > > Is that because I had already Ack-ed an earlier version of the same 
> > > patches, as noted right above Konrad's S-o-B line?
> > 
> > I must have overlooked that, partly because I expect Acked-by
> > to be below Signed-off-by (only Reported-by goes ahead of it in
> > my opinion, to reflect work/event flow).
> 
> Oh, that would be a different workflow than with Linux, where
> Acked-by has to be above the SOB.

Really? My impression of the Linux norm is that the various *-by are in
roughly chronological order (reading downwards, i.e. the list is sort of
append only), a quick glance through git log on linux.git confirms this.
e.g. it general looks like:
        Reported-by: A. Tester <a.tester@xxxxxxxxxxx>
        Signed-off-by: T. He. Author <author@xxxxxxxxxxx>
        Acked-by: Driver Maintainer <ssm@xxxxxxxxxxx>
        Tested-by: A. Tester <a.tester@xxxxxxxxxxx>
        Signed-off-by: Subsys Maintainer...

Where A. Tester reported an issue, T. He. Author fixed it, the driver
maintainer acked it, the reporter tested it and the subsystem maintainer
picked it up to forward it on.

So since you authored this patch and the George acked it your S-o-b
should be followed by George's ack. If a subsystem maintainer were to
pick up the patch and forward it on then their S-o-b would go after
Georges ack.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel