[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] x86/S3: Fix cpu pool scheduling after suspend/resume

This review is another S3 scheduler problem with the system_state variable 
introduced with the following changeset:

Specifically, the cpu_callback function that takes the CPU down during suspend, 
and back up during resume.
We were seeing situations where, after S3, only CPU0 was in cpupool0. Guest 
performance suffered greatly, since all vcpus were only on a single pcpu. 
Guests under high CPU load showed the problem much more quickly than an idle 

Removing this if condition forces the CPUs to go through the expected 
online/offline state, and be properly scheduled after S3.

This also includes a necessary partial change proposed earlier by Tomasz 
Wroblewski here:

It should also resolve the issues discussed in this thread:

Signed-off-by: Ben Guthro <benjamin.guthro@xxxxxxxxxx>
 xen/common/cpu.c     |    3 +++
 xen/common/cpupool.c |    5 -----
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/xen/common/cpu.c b/xen/common/cpu.c
index 630881e..e20868c 100644
--- a/xen/common/cpu.c
+++ b/xen/common/cpu.c
@@ -5,6 +5,7 @@
 #include <xen/init.h>
 #include <xen/sched.h>
 #include <xen/stop_machine.h>
+#include <xen/sched-if.h>
 unsigned int __read_mostly nr_cpu_ids = NR_CPUS;
 #ifndef nr_cpumask_bits
@@ -212,6 +213,8 @@ void enable_nonboot_cpus(void)
             BUG_ON(error == -EBUSY);
             printk("Error taking CPU%d up: %d\n", cpu, error);
+        if (system_state == SYS_STATE_resume)
+            cpumask_set_cpu(cpu, cpupool0->cpu_valid);
diff --git a/xen/common/cpupool.c b/xen/common/cpupool.c
index 10b10f8..a9653a8 100644
--- a/xen/common/cpupool.c
+++ b/xen/common/cpupool.c
@@ -633,10 +633,6 @@ static int cpu_callback(
     unsigned int cpu = (unsigned long)hcpu;
     int rc = 0;
-    if ( (system_state == SYS_STATE_suspend) ||
-         (system_state == SYS_STATE_resume) )
-        goto out;
     switch ( action )
     case CPU_DOWN_FAILED:
@@ -650,7 +646,6 @@ static int cpu_callback(
     return !rc ? NOTIFY_DONE : notifier_from_errno(rc);

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.