[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86/S3: Restore broken vcpu affinity on resume (v4)

>>> On 01.04.13 at 22:17, Keir Fraser <keir.xen@xxxxxxxxx> wrote:
> On 01/04/2013 20:47, "Ben Guthro" <Benjamin.Guthro@xxxxxxxxxx> wrote:
>>>> v4:
>>>> Formatting: Fix if statement spacing.
>>>> Eliminate unnecessary if statement in thaw_domains()
>>>> Suppress affinity related logging to XENLOG_DEBUG to reduce noise.
>>>> Signed-off-by: Ben Guthro <benjamin.guthro@xxxxxxxxxx>
>>> I'm not super-familiar with the save/restore paths; but it looks like
>>> a reasonable change to me:
>>> Acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
>> Thanks George.
>> Jan,
>> Is this a sufficient Ack, or does Kier need to weigh in as well?
> Acked-by: Keir Fraser <keir@xxxxxxx>
> I kind of feel this sort of thing should be done in dom0 userspace but,
> pragmatically, I know that's not really going to happen!

How would that work, considering the Dom0's vCPU affinities are
equally affected, and considering that all domains get thawed at
once? Minimally you'd have a burst of (overcommit) load on pCPU0
right after resume, and whether the system would survive that is
impossible to predict.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.