Re: [Xen-devel] [PATCH] Fix cd-insert problem not detecting type.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Stefano Stabellini writes ("Re: [PATCH] Fix cd-insert problem not detecting 
type."):
> I don't know if supporting the full disk-spec-component syntax is the
> best thing to do here:

I think regularity would be very valuable.

>  for instance you are not supposed to pass a devtype different from
> cdrom.  At the very least we need to clarify that devtype is not
> respected when passed to cd-insert.

The devtype should be checked, and devtypes other than cdrom should
produce an error.  In xl cd-insert it should default to cdrom, so this
isn't an error you'd normallys ee.

> I would hate to have to introduce yet another command to work around a
> broken one.

Quite.

> I would rather break compatibility with the existing cd-insert.

Yes.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel