[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 2/2] libxl: xl mem-set should not enforce memory limits



On Fri, 2013-03-15 at 16:25 +0000, Daniel Kiper wrote:
> xl mem-set should not enforce memory limits. If it does

NB the title says libxl but this is actually an xl change.

> then after decreasing reservation there is no chance to
> increase reservation directly from guest domain by
> writing to /sys/devices/system/xen_memory/xen_memory0/target*

This is a feature not a bug I think. It is intentional that if the host
admin sets a memory target the a guest admin cannot exceed that limit.

Ian.

> 
> Signed-off-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
> ---
>  tools/libxl/xl_cmdimpl.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index a98705e..9add281 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -2492,7 +2492,7 @@ static void set_memory_target(uint32_t domid, const 
> char *mem)
>          exit(3);
>      }
>  
> -    libxl_set_memory_target(ctx, domid, memorykb, 0, /* enforce */ 1);
> +    libxl_set_memory_target(ctx, domid, memorykb, 0, 0);
>  }
>  
>  int main_memset(int argc, char **argv)



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.