Re: [Xen-devel] [PATCH 4/8] device-tree: get_val cannot cope with cells > 2, add early_panic

[Tim Deegan <tim@xxxxxxx>]

At 17:10 +0000 on 03 Dec (1354554627), Ian Campbell wrote:
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Acked-by: Tim Deegan <tim@xxxxxxx>

> ---
> v3: early_panic instead of BUG_ON
> v2: drop unrelated white space fixup
> ---
>  xen/common/device_tree.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/xen/common/device_tree.c b/xen/common/device_tree.c
> index 9eb316f..5a0a1a6 100644
> --- a/xen/common/device_tree.c
> +++ b/xen/common/device_tree.c
> @@ -58,6 +58,9 @@ static void __init get_val(const u32 **cell, u32 cells, u64 
> *val)
>  {
>      *val = 0;
>  
> +    if ( cells > 2 )
> +        early_panic("dtb value contains > 2 cells\n");
> +
>      while ( cells-- )
>      {
>          *val <<= 32;
> -- 
> 1.7.9.1
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel