Re: [Xen-devel] [PATCH] hotplug/Linux: close lockfd after lock attempt

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2012-10-15 at 09:42 +0100, Olaf Hering wrote:
> On Mon, Oct 15, Ian Campbell wrote:
> 
> > On Sat, 2012-10-13 at 23:35 +0100, Olaf Hering wrote:
> > > On Sat, Oct 13, Olaf Hering wrote:
> > > 
> > > > hotplug/Linux: close lockfd after lock attempt
> > > > 
> > > > When a HVM guest is shutdown some of the 'remove' events can not claim
> > > > the lock for some reason. Instead they try to grab the lock in a busy
> > > > loop, until udev reaps the xen-hotplug-cleanup helper.
> > > > After analyzing the resulting logfile its not obvious what the cause is.
> > > > The only explanation is that bash (?) gets confused if the same lockfd
> > > > is opened again and again. Closing it in each iteration seem to fix the
> > > > issue.
> > > 
> > > Can be reproduced with this testcase on sles11sp2, not on openSuSE 11.4:
> > 
> > So this is a bash bug? Have you reported it against bash?
> 
> It does not happen with a newer bash: bash 3.2 from sles11sp2 fails,
> bash 4.1 from openSuSE 11.4 works.

I added a comment:
        # Some versions of bash appear to be buggy if the same 
        # $_lockfile is opened repeatedly. Close the current fd here.
and reference to the bash version in the commit message.

acked + applied. Thanks.
> 
> Olaf



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel