Re: [Xen-devel] [PATCH] do not remove kernels or modules on uninstall. (Was: Re: make uninstall can delete xen-kernels)

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> Ian Campbell <Ian.Campbell@xxxxxxxxxx> 08/23/12 8:40 AM >>>
>--- a/Makefile    Wed Aug 22 17:32:37 2012 +0100
>+++ b/Makefile    Thu Aug 23 07:38:10 2012 +0100
>@@ -228,8 +228,6 @@ uninstall:
>    rm -f  $(D)$(SYSCONFIG_DIR)/xendomains
>    rm -f  $(D)$(SYSCONFIG_DIR)/xencommons
>    rm -rf $(D)/var/run/xen* $(D)/var/lib/xen*
>-    rm -rf $(D)/boot/*xen*

But removing this line without replacement isn't right either - we at least
need to undo what "make install" did. That may imply adding an
uninstall-xen sub-target, if we don't want to come up with a suitable
pattern to do this here.

>-    rm -rf $(D)/lib/modules/*xen*
>    rm -rf $(D)$(LIBDIR)/xen* $(D)$(BINDIR)/lomount
>    rm -rf $(D)$(BINDIR)/cpuperf-perfcntr $(D)$(BINDIR)/cpuperf-xen
>    rm -rf $(D)$(BINDIR)/xc_shadow

This may also be needed for the tools - wasn't it that BINDIR, LIBDIR and
the like are now dependent on configure options?

Similarly I don't the the EFI binaries get properly cleaned up here (and
that also would better be done with a per-subdir uninstall).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel