[Xen-devel] [PATCH] do not remove kernels or modules on uninstall. (Was: Re: make uninstall can delete xen-kernels)

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2012-08-22 at 22:47 +0100, p.d@xxxxxx wrote:
> Nice time.
> 
> # make uninstall
> ...
> rm -rf //boot/*xen*
> ...
> 
> if somebody use "xen" in kernel name (maybe as suffix), so it will be deleted 
> from /boot/ too.

Ouch!

8<-------------------------

# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1345703890 -3600
# Node ID b75970f4114ec72f744f5e7f979ab50401c4629f
# Parent  89c8c855f1df234f9649e98a51724f018f4f92df
do not remove kernels or modules on uninstall.

The pattern used is very broad and will delete any kernel with xen in
its filename, likewise modules, including those which come packages
from the distribution etc.

I don't think this was ever the right thing to do but it is doubly
wrong now that Xen does not even build or install a kernel by default.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff -r 89c8c855f1df -r b75970f4114e Makefile
--- a/Makefile  Wed Aug 22 17:32:37 2012 +0100
+++ b/Makefile  Thu Aug 23 07:38:10 2012 +0100
@@ -228,8 +228,6 @@ uninstall:
        rm -f  $(D)$(SYSCONFIG_DIR)/xendomains
        rm -f  $(D)$(SYSCONFIG_DIR)/xencommons
        rm -rf $(D)/var/run/xen* $(D)/var/lib/xen*
-       rm -rf $(D)/boot/*xen*
-       rm -rf $(D)/lib/modules/*xen*
        rm -rf $(D)$(LIBDIR)/xen* $(D)$(BINDIR)/lomount
        rm -rf $(D)$(BINDIR)/cpuperf-perfcntr $(D)$(BINDIR)/cpuperf-xen
        rm -rf $(D)$(BINDIR)/xc_shadow



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel