Re: [Xen-devel] [PATCH v10 16/19] libxl: call hotplug scripts for nic devices from libxl

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-07-20 at 17:01 +0100, Ian Campbell wrote:
> > +        switch (nictype) {
> > +        case LIBXL_NIC_TYPE_VIF_IOEMU:
> > +            env[nr++] = "INTERFACE";
> > +            env[nr++] = libxl__strdup(gc, libxl__device_nic_devname(gc,
> > +                                                      dev->domid, 
> > dev->devid,
> > +                                                      
> > LIBXL_NIC_TYPE_VIF_IOEMU));
> 
> Is this fall-through of the case deliberate? If so then a comment would
> be good.

Also -- isn't the strdup redendant here too?



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel