Re: [Xen-devel] [PATCH] Fix pygrub install.

[George Dunlap <George.Dunlap@xxxxxxxxxxxxx>]

On Wed, May 30, 2012 at 5:56 PM, Anthony PERARD
<anthony.perard@xxxxxxxxxx> wrote:
> The script pygrub is currently installed in the wrong location. Instead of
> /usr/lib/xen/bin, the script is installed in $destdir/usr/lib/xen/bin.
> $(DESTDIR) is apply twice.
>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Hmm -- I'm sure I checked this... but you're right, $(DESTDIR) IS IN
THE --root command.

The strange thing is that there *is* a pygrub in the right place, so
it appears that thefollowing line ($INSTALL_PYTHON_PROG) is redundant?

Anyway:

Acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

> ---
>  tools/pygrub/Makefile |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tools/pygrub/Makefile b/tools/pygrub/Makefile
> index f8c5262..af2b8a5 100644
> --- a/tools/pygrub/Makefile
> +++ b/tools/pygrub/Makefile
> @@ -12,7 +12,7 @@ build:
>  install: all
>        CC="$(CC)" CFLAGS="$(CFLAGS)" $(PYTHON) setup.py install \
>                $(PYTHON_PREFIX_ARG) --root="$(DESTDIR)" \
> -               --install-scripts=$(DESTDIR)/$(PRIVATE_BINDIR) --force
> +               --install-scripts=$(PRIVATE_BINDIR) --force
>        $(INSTALL_PYTHON_PROG) src/pygrub $(DESTDIR)/$(PRIVATE_BINDIR)/pygrub
>        $(INSTALL_DIR) $(DESTDIR)/var/run/xend/boot
>        ln -sf $(PRIVATE_BINDIR)/pygrub $(DESTDIR)/$(BINDIR)
> --
> Anthony PERARD
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel