Re: [Xen-devel] [PATCH v4 04/10] libxl: convert libxl_device_disk_add to an asyn op

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2012-05-29 at 15:26 +0100, Ian Jackson wrote:
> 
> > @@ -1859,11 +1883,13 @@ int libxl_cdrom_insert(libxl_ctx *ctx,
> uint32_t domid, libxl_device_disk *disk)
> >      ret = 0;
> > 
> >      libxl_device_disk_remove(ctx, domid, disks + i, 0);
> > -    libxl_device_disk_add(ctx, domid, disk);
> > +    /* fixme-ao */
> 
> We need to fix this in the API, at least by making libxl_cdrom_insert
> take an ao_how at some point.  But not in this patch, indeed. 

In yesterday's TODO I said:

            * libxl_cdrom_insert. Should be easy once
              disk_{add,remove} done. Nobody is looking at this? This
              is basically a helper function and its functionality can
              be implemented in terms of the libxl_disk_*
              interfaces. We could therefore consider marking this
              function as substandard and subject to change in the
              future. We could also consider simply moving it into xl
              as a helper function and revisting for 4.3.

I'm quite interested in thoughts on that ;-)

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel