[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v6 05/11] libxl: introduce libxl__device_disk_add

Stefano Stabellini writes ("Re: [PATCH v6 05/11] libxl: introduce 
> On Fri, 18 May 2012, Ian Jackson wrote:
> > Can't this be done in such a way that the diff isn't "delete this
> > function completely" followed by "here is a new function" ?
> I don't know. Do you have any suggestions?  TBH if I were you, I would
> just open two terminals and compare line by line, but let me know if you
> want to do something specific..

If you leave all the existing code for the internal function in place
and simply change the function declaration and prologue, and
corresponding epilogue, you should find that diff doesn't mention the
contents at all.

The new public wrapper will of course be new.

> ATM there are no hidden functions in libxl.c.
> Do you want to change this "policy"?

I think there is no reason for this and it is not something I want to
preserve.  The distinction between internal and external is not a good
basis for which file something should be in.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.