Re: [Xen-devel] [PATCH v6 05/11] libxl: introduce libxl__device_disk_add

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 18 May 2012, Ian Jackson wrote:
> Stefano Stabellini writes ("[PATCH v6 05/11] libxl: introduce 
> libxl__device_disk_add"):
> > Introduce libxl__device_disk_add that takes an additional
> > xs_transaction_t paramter.
> > Implement libxl_device_disk_add using libxl__device_disk_add.
> 
> Can't this be done in such a way that the diff isn't "delete this
> function completely" followed by "here is a new function" ?

I don't know. Do you have any suggestions?  TBH if I were you, I would
just open two terminals and compare line by line, but let me know if you
want to do something specific..


> I don't really understand why you want to move the function at all,
> TBH.  I think keeping the public wrapper and the internal
> implementation together is fine.  There is no need IMO to move the
> internal function to libxl_internal.c.

ATM there are no hidden functions in libxl.c.
Do you want to change this "policy"?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel