Re: [Xen-devel] [PATCH] libxl: Introduce LIBXL_DOMAIN_TYPE_INVALID to make gcc happy

[Dario Faggioli <raistlin@xxxxxxxx>]

On Fri, 2012-05-18 at 15:39 +0100, Ian Campbell wrote:
> > Which actually seems to be right:
> > 
> > $ grep LIBXL_DOMAIN_TYPE_INVALID tools/* -R
> > tools/libxl/libxl_dm.c:    case LIBXL_DOMAIN_TYPE_INVALID:
> > tools/libxl/libxl_dm.c:    case LIBXL_DOMAIN_TYPE_INVALID:
> > tools/libxl/libxl_dom.c:        return LIBXL_DOMAIN_TYPE_INVALID;
> > tools/libxl/libxl_dom.c:        return LIBXL_DOMAIN_TYPE_INVALID;
> > tools/libxl/libxl.c:        case LIBXL_DOMAIN_TYPE_INVALID:
> > 
> > Am I missing something?
> 
> This should be defined in tools/libxl/libxl_types.idl but the patch
> doesn't seem to add it.
> 
Yep, I'm adding it myself with the attached patch, but I'm now getting
this:

_libxl_types.c: In function âlibxl_domain_build_info_disposeâ:
_libxl_types.c:91:5: error: enumeration value âLIBXL_DOMAIN_TYPE_INVALIDâ not 
handled in switch [-Werror=switch]
_libxl_types.c: In function âlibxl_domain_build_info_init_typeâ:
_libxl_types.c:284:5: error: enumeration value âLIBXL_DOMAIN_TYPE_INVALIDâ not 
handled in switch [-Werror=switch]
testidl.c: In function âlibxl_domain_build_info_rand_initâ:
testidl.c:366:5: error: enumeration value âLIBXL_DOMAIN_TYPE_INVALIDâ not 
handled in switch [-Werror=switch]
_libxl_types.c: In function âlibxl_domain_build_info_gen_jsonâ:
_libxl_types.c:1713:5: error: enumeration value âLIBXL_DOMAIN_TYPE_INVALIDâ not 
handled in switch [-Werror=switch]
cc1: all warnings being treated as errors

:-O

Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://retis.sssup.it/people/faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: DOMAIN_TYPE_INVALID.patch
Description: Text Data

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel