Re: [Xen-devel] [PATCH] libxl: Introduce LIBXL_DOMAIN_TYPE_INVALID to make gcc happy

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2012-05-18 at 15:30 +0100, Dario Faggioli wrote:
> On Fri, 2012-05-18 at 14:21 +0200, Christoph Egger wrote:
> > Introduce LIBXL_DOMAIN_TYPE_INVALID.
> > Change libxl__domain_type() to return LIBXL_DOMAIN_TYPE_INVALID rather
> > hardcoding -1.
> > Adjust code pieces where gcc 4.5.3 claims that LIBXL_DOMAIN_TYPE_INVALID
> > is not handled.
> > 
> > This fixes the build error with gcc 4.5.3 reported here:
> > http://lists.xen.org/archives/html/xen-devel/2012-05/msg01269.html
> > 
> I was also running into that error and thus I applied this patch, which
> brought me here:
> 
> libxl.c: In function âlibxl_primary_console_execâ:
> libxl.c:1233:14: error: âLIBXL_DOMAIN_TYPE_INVALIDâ undeclared (first use in 
> this function)
> libxl.c:1233:14: note: each undeclared identifier is reported only once for 
> each function it appears in
> 
> Which actually seems to be right:
> 
> $ grep LIBXL_DOMAIN_TYPE_INVALID tools/* -R
> tools/libxl/libxl_dm.c:    case LIBXL_DOMAIN_TYPE_INVALID:
> tools/libxl/libxl_dm.c:    case LIBXL_DOMAIN_TYPE_INVALID:
> tools/libxl/libxl_dom.c:        return LIBXL_DOMAIN_TYPE_INVALID;
> tools/libxl/libxl_dom.c:        return LIBXL_DOMAIN_TYPE_INVALID;
> tools/libxl/libxl.c:        case LIBXL_DOMAIN_TYPE_INVALID:
> 
> Am I missing something?

This should be defined in tools/libxl/libxl_types.idl but the patch
doesn't seem to add it.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel