Re: [Xen-devel] [PATCH] libxl: do not overwrite user supplied config when running bootloader

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH] libxl: do not overwrite user supplied config when 
running bootloader"):
> @@ -1757,9 +1772,14 @@ struct libxl__bootloader_state {
>      libxl__ao *ao;
>      libxl__run_bootloader_callback *callback;
>      libxl__bootloader_console_callback *console_available;
> -    libxl_domain_build_info *info; /* u.pv.{kernel,ramdisk,cmdline} updated 
> */
> +    const libxl_domain_build_info *info;
>      libxl_device_disk *disk;
>      uint32_t domid;
> +    /* outputs, call must set kernel and ramdisk to point to a file
> +     * reference which will be updated and mapped, cmdline will be
> +     * updated */
> +    libxl__file_reference *kernel, *ramdisk;
> +    const char *cmdline;

You mean "caller must set" ?  And "to file references" since they're
not the same reference.  (Also, comma splices, ew.)

Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel