[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] [mq]: patch_libxl_get_console_tty.diff

Hi, Ian 

thanks your reply. 

Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote: 
>Bamvor Jian Zhang writes ("[Xen-devel] [PATCH] [mq]: 
>> diff -r 9dda0efd8ce1 -r 4a6043e1434a tools/libxl/libxl.c

>Thanks for posting this but was int actually inteded for inclusion in
>the tree ?  If so we need a commit message and a Signed-off-by and so
>forth.  Also we may be too late for 4.2 considering the feature
I am sorry maybe there are something wrong in my hgrc settings. the patch 
including comments and Signed-off-by in my ".hg/patches" directory. 
I understand that 4.2 is almost release. meanwhile, my patch is useful for 
adding a api in libvirt for xenlight open console commands.

>> +int libxl_get_console_tty(libxl_ctx *ctx, uint32_t domid, char **path)
>> +{
>We already have various functions to refer to and open consoles, which
>have much of this functionality in them already.  That shouldn't be
>Also we need to make a policy decision about whether the fact that the
>console looks like a tty is a part of the API.
sorry i only found one api about open console is libxl_console_exec. 
libxl_console_exec call xenconsole command directly which is not compatible 
with libvirt open console api. libvirt open console want a console device path 
and handle the console by libvirt itself. libvirt xen(not xenlight) driver read 
console path from xenstore directly which is prohibited by libvirt xenlight 
So, because these reasons, i guess add this simple api to return console path 
to libvirt is a good choice. it is useful for libvirt and do not break libxl 
>> +/* libxl_get_console_tty get the tty path from xenstore according to the 
>> + * domain id. 
>> + */
>> +int libxl_get_console_tty(libxl_ctx *ctx, uint32_t domid, char **path);
>In any case the doc comment should not mention xenstore.  It should
>also document the memory allocation behaviour.
I will change it in my next version. 


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.