Re: [Xen-devel] [PATCH] [mq]: patch_libxl_get_console_tty.diff

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Bamvor Jian Zhang writes ("[Xen-devel] [PATCH] [mq]: 
patch_libxl_get_console_tty.diff"):
> diff -r 9dda0efd8ce1 -r 4a6043e1434a tools/libxl/libxl.c
> --- a/tools/libxl/libxl.c     Fri Apr 27 17:57:55 2012 +0200
> +++ b/tools/libxl/libxl.c     Sat Apr 28 22:36:56 2012 +0800
> @@ -15,6 +15,8 @@
>   */
>  
>  #include "libxl_osdeps.h"
> +//#include "libxl_osdeps.h"
> +//#include "libxl_osdeps.h"

Thanks for posting this but was int actually inteded for inclusion in
the tree ?  If so we need a commit message and a Signed-off-by and so
forth.  Also we may be too late for 4.2 considering the feature
freeze.

> +int libxl_get_console_tty(libxl_ctx *ctx, uint32_t domid, char **path)
> +{

We already have various functions to refer to and open consoles, which
have much of this functionality in them already.  That shouldn't be
duplicated.

Also we need to make a policy decision about whether the fact that the
console looks like a tty is a part of the API.

> +/* libxl_get_console_tty get the tty path from xenstore according to the 
> + * domain id. 
> + */
> +int libxl_get_console_tty(libxl_ctx *ctx, uint32_t domid, char **path);

In any case the doc comment should not mention xenstore.  It should
also document the memory allocation behaviour.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel