Re: [Xen-devel] [PATCH v5 8/8] libxl__device_disk_local_attach: wait for state "connected"

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 4 May 2012, Ian Campbell wrote:
> > @@ -598,11 +599,24 @@ char * libxl__device_disk_local_attach(libxl__gc *gc,
> >              break;
> >      }
> >  
> > +    if (disk->vdev != NULL) {
> > +        rc = libxl__device_from_disk(gc, LIBXL_TOOLSTACK_DOMID, disk, 
> > &device);
> > +        if (rc < 0)
> > +            goto out;
> > +        be_path = libxl__device_backend_path(gc, &device);
> > +        rc = libxl__wait_for_backend(gc, be_path, "4");
> > +        if (rc < 0)
> > +            goto out;
> > +    }
> > +
> > +    *new_disk = disk;
> > +    return dev;
> >   out:
> >      if (t != XBT_NULL)
> >          xs_transaction_end(ctx->xsh, t, 1);
> 
> There's no way to reach the preceding "return dev" with the transaction
> still open? Previously we would have fallen through and done it.

Yes, there is no way.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel