Re: [Xen-devel] [PATCH v5 2/8] libxl: libxl__device_disk_local_attach return a new libxl_device_disk

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Stefano Stabellini writes ("Re: [PATCH v5 2/8] libxl: 
libxl__device_disk_local_attach return a new libxl_device_disk"):
> On Fri, 4 May 2012, Ian Jackson wrote:
> > Stefano Stabellini writes ("[PATCH v5 2/8] libxl: 
> > libxl__device_disk_local_attach return a new libxl_device_disk"):
> > >              LIBXL__LOG(ctx, LIBXL__LOG_DEBUG, "locally attaching qdisk 
> > > %s\n",
> > > -                       disk->pdev_path);
> > > +                       in_disk->pdev_path);
> > 
> > I think in_disk->pdev_path can be NULL here ?
> 
> It cannot, unless a wrong configuration was provided. In that case we'll
> fail to open the empty disk later on.

But not until we've called LIBXL__LOG(..., "%s", NULL) which is
undefined behaviour (according to the spec) and which on all systems
we are likely to run on will print "(null)".

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel