[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Fix xencommons for NetBSD

On Fri, 2011-07-15 at 12:44 +0100, Olaf Hering wrote:
> On Fri, Jul 15, Roger Pau Monnà wrote:
> > Another one, used -n instead of -z when testing the presence of
> > XENSTORED_ROOTDIR. Sorry for this mess, I'm not really used to make
> > shell init scripts.
> +       xenstored_pid=$(check_pidfile ${XENSTORED_PIDFILE} 
> ${SBINDIR}/xenstored)
> +       if test -z $xenstored_pid; then
> Doesnt this expand to 'if test -z ; then' if check_pidfile returns
> nothing, causing a shell syntax error?

Seems not:
$ dash -c 'if test -z ; then echo foo ; fi'
$ posh -c 'if test -z ; then echo foo ; fi'

(maybe NetBSD sh(1) or test(1) differs though)

> Better do 'if test -z "$variable" ; then'.

That's still good advice IMHO.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.