Re: [Xen-devel] [PATCH] Fix xencommons for NetBSD

[Olaf Hering <olaf@xxxxxxxxx>]

On Fri, Jul 15, Roger Pau Monnà wrote:

> Another one, used -n instead of -z when testing the presence of
> XENSTORED_ROOTDIR. Sorry for this mess, I'm not really used to make
> shell init scripts.

+       xenstored_pid=$(check_pidfile ${XENSTORED_PIDFILE} ${SBINDIR}/xenstored)
+       if test -z $xenstored_pid; then

Doesnt this expand to 'if test -z ; then' if check_pidfile returns
nothing, causing a shell syntax error?
Better do 'if test -z "$variable" ; then'.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel