[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [PATCH] xen_disk: treat "aio" as "raw"

On 06/24/2011 04:50 PM, stefano.stabellini@xxxxxxxxxxxxx wrote:
From: Stefano Stabellini<stefano.stabellini@xxxxxxxxxxxxx>

Sometimes the toolstack uses "aio" without an additional format
identifier, in such cases use "raw".

Shouldn't this rather be a patch to the toolstack then? We do automatic file format recognition as default. I find magical "aio equals raw" subtleties rather unintuitive.

Signed-off-by: Stefano Stabellini<stefano.stabellini@xxxxxxxxxxxxx>
  hw/xen_disk.c |    2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/hw/xen_disk.c b/hw/xen_disk.c
index 801da58..745127d 100644
--- a/hw/xen_disk.c
+++ b/hw/xen_disk.c
@@ -633,6 +633,8 @@ static int blk_init(struct XenDevice *xendev)
              blkdev->filename  = blkdev->params;
+    if (!strcmp("aio", blkdev->fileproto))
+        blkdev->fileproto = "raw";


      if (blkdev->mode == NULL) {
          blkdev->mode = xenstore_read_be_str(&blkdev->xendev, "mode");


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.