[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [Qemu-devel] [PATCH v2] xen_disk: cope with missing xenstore "params" node

On Sat, 25 Jun 2011, Peter Maydell wrote:
> On 24 June 2011 17:35,  <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> > +out_error:
> > + Â Âqemu_free(blkdev->params);
> > + Â Âqemu_free(blkdev->mode);
> > + Â Âqemu_free(blkdev->type);
> > + Â Âqemu_free(blkdev->dev);
> > + Â Âqemu_free(blkdev->devtype);
> > + Â Âreturn -1;
> It occured to me that could result in a double-free if it's
> possible to call init again (or to call free) after the init
> routine has returned failure. I don't know enough about the
> Xen device lifecycle to know if that's possible, though -- is it?

It shouldn't happen, but xen_disk should be able to cope with it
I am going to resend the patch again setting to NULL all the blkdev
fields after freeing them.
Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.