[Xen-devel] Re: [PATCH 09/15] xen/trace: add tlb flush tracepoints

[Steven Rostedt <rostedt@xxxxxxxxxxx>]

On Thu, 2011-06-23 at 12:52 -0700, Jeremy Fitzhardinge wrote:
> On 06/21/2011 07:07 AM, Konrad Rzeszutek Wilk wrote:
> >> +TRACE_EVENT(xen_mmu_flush_tlb,
> >> +      TP_PROTO(int x),
> >> +      TP_ARGS(x),
> >> +      TP_STRUCT__entry(__array(char, x, 0)),
> >> +      TP_fast_assign((void)x),
> >> +      TP_printk("%s", "")
> > Um, why not just "" without the %s?
> 
> Uh, vararg macro bogusness; need to supply 2 args.
> 

Ouch! I didn't notice this before. Do you really need this empty event?
Why not just use the function tracer for this? It should work.

If you really need something like this, maybe I'll add a
DEFINE_EVENT_NOARGS() that will not require arguments and can eliminate
a lot of code that TRACE_EVENT() adds.

-- Steve



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel