[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH V4] libxl, Introduce a QMP client

  • To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Wed, 22 Jun 2011 14:09:27 +0100
  • Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
  • Delivery-date: Wed, 22 Jun 2011 06:12:55 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; b=uBhmz6MlATwnztqDwJqF+5aF9QcKKsXmDMQCCmKqv6kHCBwiLxxj3O1WDNWDxQPfym B4jdTEdsLPSrdmrjPFFXfxO0u38U7zqRvuNALvAILJbFqnWHQDg9mXzPQmQ6u72HOOpK LzBdIljFsuL+gMs+cWZF7PquorcfntYHvG6CE=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

On Mon, Jun 20, 2011 at 15:50, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> wrote:
> anthony.perard@xxxxxxxxxx writes ("[Xen-devel] [PATCH V4] libxl, Introduce a 
> QMP client"):
>> QMP stands for QEMU Monitor Protocol and it is used to query information
>> from QEMU or to control QEMU.
> Thanks for this; it's coming along. ÂI have some comments....


>> +/* QMP Command that can be send */
>> +enum libxl__qmp_command_e {
>> +};
> ...
>> +_hidden int libxl__qmp_send_command(libxl__qmp_handler *qmp, 
>> libxl__qmp_command_e command);
> I'm not entirely convinced by this interface. ÂWouldn't it be better
> to have a specific function for each command ? ÂAfter all commands may
> have arguments. ÂSomething like:
> _hidden int libxl__qmp_send_query_chardev(libxl__qmp_handler *qmp);

Indeed, it should be better to have specific functions. Some commands
will have arguments. And have a generic function for all of them will
maybe not be easy and not clear.

Anthony PERARD

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.