Re: [Xen-devel] [PATCH 02 of 22] tools: merge several bitop functions into xc_bitops.h

[Olaf Hering <olaf@xxxxxxxxx>]

On Tue, Jun 21, Ian Jackson wrote:

> Olaf Hering writes ("[Xen-devel] [PATCH 02 of 22] tools: merge several bitop 
> functions into xc_bitops.h"):
> > tools: merge several bitop functions into xc_bitops.h
> 
> This seems to break the stubdom build, I'm afraid.

> xc_domain_save.c:30:23: error: xc_bitops.h: No such file or directory

(I just ran 'make tools' to verify my changes, not make or 'make stubdom')

Why are the symlinks not updated? I can not reproduce the failure in a
fresh build.  xc_domain_save.c references other files like xc_private.h
in the same directory. 
So I think the bug is not strictly in my change, but may point to some
other bug.


Maybe its related to the issue I ran often while working on this series:
Repeated hg qpush/qpop with a patch that adds a new header or removes an
existing one, does not update the .*.d file. As a result, make fails
because there is 'no rule to make target foo.h'. The only way is to do a
make clean in these directories to remove the .*.d files.


...
time passes.
...


I can reproduce it now with a fresh build without patches, then apply
just this patch and run make again.
First tools/xenpaging/ fails because there is now 'no rule to make
target bitops.h'. A 'rm tools/xenpaging/.*.d ; make' fixes it.
Now it fails as you describe.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel