[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1 of 2] tools/libxc: Remus Checkpoint Compression

Shriram Rajagopalan writes ("[Xen-devel] [PATCH 1 of 2] tools/libxc: Remus 
Checkpoint Compression"):
> tools/libxc: Remus Checkpoint Compression
> Instead of sending dirty pages of guest memory as-is, use a simple
> compression algorithm that sends a RLE-encoded XOR of the page
> against its last sent copy.  A small LRU cache is used to hold
> recently dirtied pages. Pagetable pages are sent as-is, as they are
> canonicalized at sender side and uncanonicalized at receiver.

Thanks for this but it's very hard to review due to wrap damage on my

-                    if ( wruncached(io_fd, live, page, PAGE_SIZE) !=
+                    if (compression)
+                    {
+                        /* Add the pagetable page, raw into the page buffer */
+                        if (xc_remus_add_page(xch, remus_ctx, page,
pfn, 1) < 0)
+                        {
+                            /* We are out of buffer space to hold dirty pages.
+                             * Compress and flush the current buffer to
make space.
+                             * --This is a corner case, that slows down

Please keep your lines down to 75 characters or so.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.