Re: [Xen-devel] [PATCH] [linux-2.6.39.x for xen] tmem: self-ballooning and frontswap-selfshrinking

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2011-06-09 at 18:21 +0100, Daniel Kiper wrote:
> On Mon, Jun 06, 2011 at 03:12:28PM -0700, Dan Magenheimer wrote:
> 
> [...]
> 
> > +static void selfballoon_process(struct work_struct *work)
> > +{
> > +   extern unsigned long vm_get_committed_as(void);
> > +   unsigned long cur_pages, goal_pages, tgt_pages;
> > +   int reset_timer = 0;
> > +
> > +   if (balloon_stats.selfballooning_enabled) {
> > +           tgt_pages = cur_pages = totalram_pages;
> 
> tgt_pages = cur_pages = balloon_stats.current_pages;

Linux coding style prefers to avoid these multiple assignments. It
favours e.g.
        tgt_pages = balloon_stats.current_pages;
        cur_pages = balloon_stats.current_pages;
etc.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel