Re: [Xen-devel] [PATCH] libxl: add all pci devices to xenstore at once (during VM create)

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 10 Jun 2011, Marek Marczykowski wrote:
> # HG changeset patch
> # User Marek Marczykowski <marmarek@xxxxxxxxxxxx>
> # Date 1307661438 -7200
> # Node ID 4b392511ae0840fba66c40aa2788dc1ff402b6e8
> # Parent  b2b8fef3732c10f012fc209d2850e80d95471582
> libxl: add all pci devices to xenstore at once (during VM create)
> 
> When adding pci devices one by one, pciback notice only the first one. For
> every next, "state" is left as is (usualy "4" in that time), so backend will
> not rescan xenstore. So when VM is starting all devices should be added at 
> once
> and then backend can initialize it.
> 
> This applies only to pci, because only pci backend have one xenstore dir for
> multiple devices.
> 
> Signed-off-by: Marek Marczykowski <marmarek@xxxxxxxxxxxx>
> 
> diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
> --- a/tools/libxl/libxl_create.c
> +++ b/tools/libxl/libxl_create.c
> @@ -521,6 +521,12 @@ static int do_domain_create(libxl__gc *g
>  
>      for (i = 0; i < d_config->num_pcidevs; i++)
>          libxl__device_pci_add(gc, domid, &d_config->pcidevs[i], 1);
> +    ret = libxl__create_pci_backend(gc, domid, d_config->pcidevs, 
> d_config->num_pcidevs);
> +    if (ret < 0) {
> +        fprintf(stderr,"xl: fatal error: %s:%d, rc=%d: 
> libxl_create_pci_backend\n",
> +                __FILE__,__LINE__, ret);
> +        goto error_out;
> +    }
>  
>      if ( cb && (d_config->c_info.hvm || d_config->b_info.u.pv.bootloader )) {
>          if ( (*cb)(ctx, domid, priv) )

Please use LIBXL__LOG rather than fprintf.
The rest of the patch is fine, thanks.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel