[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [Patch] Enable SMEP CPU feature support for XEN itself

  • To: "Li, Xin" <xin.li@xxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>, "Yang, Wei Y" <wei.y.yang@xxxxxxxxx>
  • From: Keir Fraser <keir.xen@xxxxxxxxx>
  • Date: Fri, 03 Jun 2011 13:34:04 +0100
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 03 Jun 2011 05:35:33 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=oB4W/7pTt/Cm+M58Ss9AA85LaCwHVx8qaHeuz6wdVbJem4zQnN3F56bG1wcTpui6Vv 7aOKE5qNuB7fB5iDdW5f88rnjpd++cncu5766a3IA2iWt46RIUHL7iLIP+zBjSJdigQi Jx0RQXMrGOiHNsV//IDzCv71xFP45+QONbg4w=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcwhKSFqC1+9aLNySkqezZkJGvVaUgACElDwAApQ4SEABxMYEAAbN9UwAAGrA2k=
  • Thread-topic: [Xen-devel] [Patch] Enable SMEP CPU feature support for XEN itself

On 03/06/2011 12:54, "Li, Xin" <xin.li@xxxxxxxxx> wrote:

>>> The whole point of setup_clear_cpu_cap() is that it only needs to run on the
>>> BP and the change gets picked up by every AP automatically as it boots.
>> Yeah, and we can't do leaf 7.0 detect in generic_identify. Or will again set
>> SMEP in
>> capabilities, but it should be ok.
> I tried to not do leaf 7.0 detect on AP booting code, but system behaves
> abnormally
> (not hang, but "su -" never returns, after just revert the change, it runs
> well).
> While at this point I want to focus on SMEP logic, we can make the
> improvements,
> to move such initialization to BP code only, later.  Also it makes no much
> sense to only
> move disable_smep that way, we should move all such variables.

Just get another rev of the patches out and we'll iterate if necessary.

 -- Keir

> Thanks!
> -Xin

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.