Re: [Xen-devel] [PATCH 02 of 10] libxl: Do not start stubdom when not needed

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2011-06-02 at 23:35 +0100, Marek Marczykowski wrote:
> # HG changeset patch
> # User Marek Marczykowski <marmarek@xxxxxxxxxxxx>
> # Date 1306962900 -7200
> # Node ID 59cff6b471f3f0c1e91349ed6653a47a40d4fd55
> # Parent  e3a3f5cc95349e92b7cb8b1448e999ffc16bd060
> libxl: Do not start stubdom when not needed
> 
> Do not start stubdom when there is any disk - only when there are disks
> requiring it.
> 
> Signed-off-by: Marek Marczykowski <marmarek@xxxxxxxxxxxx>

What tree is your series against? This same issue was fixed by
23044:d4ca456c0c25 in mid-March.

In general you need to post patches against a reasonably recent
xen-unstable. You can also recommend patches (either new ones or
existing commits in xen-unstable) for backporting to the x.y-testing
trees if you think that is necessary.

I though 23044:d4ca456c0c25 had already been backported to 4.1-testing
but it seems not, Keir can we do so please?

Ian.

> 
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -828,8 +828,14 @@
>          goto out;
>      }
>  
> -    if (nr_disks > 0 && !libxl__blktap_enabled(&gc))
> -        ret = 1;
> +    if (nr_disks > 0 && !libxl__blktap_enabled(&gc)) {
> +        for (i = 0; i < nr_disks; i++) {
> +            if (disks[i].backend == DISK_BACKEND_TAP || disks[i].backend == 
> DISK_BACKEND_QDISK) {
> +                ret = 1;
> +                goto out;
> +            }
> +        }
> +    }
>  
>  out:
>      libxl__free_all(&gc);
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel